refactor(hnsw): use turbo for distance calculation - #735
Merged
Merged
Conversation
iaojnh
reviewed
Sep 21, 2026
…into refactor/hnsw_on_turbo
iaojnh
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts migrating HNSW distance calculation from the legacy
IndexMetriccallback mechanism to the Turbo quantizer interface.The goal is to make quantizers own vector encoding, query preprocessing, distance dispatch, and dequantization, allowing the old converter/reformer and direct metric invocation paths to be removed as the remaining quantizers are migrated.
What changed
Current migration scope
The new quantizer-owned distance path is currently enabled for dense FP32 HNSW indexes using:
Other configurations temporarily continue to use the legacy distance path until their Turbo quantizers are integrated.
Motivation
Previously, HNSW distance calculation was spread across converters, reformers,
IndexMetric, and streamer-level function callbacks. This made encoding and distance dispatch separate concerns and required HNSW to understand implementation-specific details.Moving distance calculation behind the Turbo quantizer interface provides one owner for:
This simplifies HNSW and establishes a common path for removing the old distance invocation mechanism.
Compatibility